Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment/ccip/changeset: add chain test #15891

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from
Draft

Conversation

makramkd
Copy link
Contributor

Requires

Supports

AnieeG and others added 29 commits December 6, 2024 16:47
Copy link
Contributor

github-actions bot commented Jan 10, 2025

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (.) , Core Tests (go_core_tests) , GolangCI Lint (integration-tests) , test-scripts , Core Tests (go_core_tests_integration) , GolangCI Lint (deployment) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan

1. File is not goimports-ed with -local:

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Source of Error:
Golang Lint (deployment)	2025-01-10T13:58:29.8174366Z deployment/ccip/changeset/cs_add_chain_test.go:8: File is not `goimports`-ed with -local github.com/smartcontractkit/chainlink (goimports)
Golang Lint (deployment)	2025-01-10T13:58:29.8175414Z 	"github.com/ethereum/go-ethereum/common"

Why: The file cs_add_chain_test.go is not formatted according to the goimports tool with the -local flag set to github.com/smartcontractkit/chainlink.

Suggested fix: Run goimports with the -local flag on the file to ensure it is correctly formatted.

2. Consider pre-allocating apps:

[A 1 <= 10 words sentence that describes the error]:[job id where the error happened]

Source of Error:
Golang Lint (deployment)	2025-01-10T13:58:29.8219715Z ##[error]deployment/ccip/changeset/cs_add_chain_test.go:144:2: Consider pre-allocating `apps` (prealloc)
Golang Lint (deployment)	2025-01-10T13:58:29.8220749Z 	var apps []changesetcommon.ChangesetApplication
Golang Lint (deployment)	2025-01-10T13:58:29.8221220Z 	^

Why: The variable apps is declared without pre-allocating memory, which can lead to inefficient memory usage.

Suggested fix: Pre-allocate the slice apps with an appropriate capacity if the size is known beforehand to improve performance.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Base automatically changed from ccip-4110-migration-test to develop January 10, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants